Site Editor: Add theme.json to export file #39048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
changed the title
7 tasks
|
To the point of collapsing user/theme data here is how we have experimented with it in a Block Creation plugin. This is the resulting JSON I expect for 'theme provided' and 'user-overrided' values. |
|
@Mamaduka As we talked yesterday, I've pushed some changes that add a new method |
oandregal
reviewed
Feb 25, 2022
Mamaduka
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
|
Thank you, @oandregal 🦸 |
|
@oandregal I made small code style change in 7f4f48d. Should we land this to get more feedback from testing? |
|
It would be good to update the text here: |
|
@scruffian, I was also thinking about changing the text. Any suggestions? |
|
How's this? |
|
Size Change: +405 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Thanks, @scruffian. |
36 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #27528
Supersedes #36619
Adds global style settings (as theme.json) to the site export file.
PR also overrides the core REST API endpoint for export functionality.
Testing Instructions
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).