Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the remaining steps needed for creating themes without code #38199

Closed
carolinan opened this issue Jan 25, 2022 · 4 comments
Closed

Complete the remaining steps needed for creating themes without code #38199

carolinan opened this issue Jan 25, 2022 · 4 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues

Comments

@carolinan
Copy link
Contributor

carolinan commented Jan 25, 2022

What problem does this address?

Changes made to block themes can be exported from the Site Editor. But the export it is not a complete working theme.
If the export was complete, users could create themes without knowing any code.

What is your proposed solution?

The following is missing for it to be a complete theme:

Short term:

These two additional files are all that is missing to be able to activate the theme.

Long term:

@carolinan carolinan added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Jan 25, 2022
@dreaddymck
Copy link

An option to import/replace would be nice as well.

@draganescu draganescu added the [Type] Enhancement A suggestion for improvement. label Feb 21, 2022
@draganescu draganescu self-assigned this Feb 21, 2022
@draganescu draganescu added the [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues label Feb 21, 2022
@draganescu draganescu removed their assignment Feb 21, 2022
@scruffian
Copy link
Contributor

What do you think about just exporting the whole theme, like this #39202 ?

@carolinan
Copy link
Contributor Author

I am not sure. Of course we need to look at it from user perspective too, not only our developer perspective.

-It is useful to get all the changes, since then we as developers do not need to copy paste template markup
-Will users believe they are creating a new theme? Will they not take their new zip file and try to install it? They would end up with two themes with the same name? Will the zip and folder have a unique name, or the current theme name?

@scruffian
Copy link
Contributor

We have made some good progress on this. What do you think about closing it in favour of #39189?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
None yet
Development

No branches or pull requests

4 participants