Scripts: Fix Entry points are not detected in Windows OS #38781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
Size Change: +506 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
gziolo
added
[Package] Scripts
gziolo
reviewed
Feb 14, 2022
There was a problem hiding this comment.
Oh no, this issue is back. We have now verification for Windows through a GitHub action but the test block is put directly in the src folder so it didn’t catch it 🙈
Thank you for opening a fix so quickly. I left a comment but it probably doesn’t matter that much. Let’s test it and land as soon as possible.
|
I've refactored the code. |
gziolo
approved these changes
Feb 15, 2022
|
Tested locally and everything works great 👏🏻 |
gziolo
added a commit
that referenced
this pull request
Feb 15, 2022
* Scripts: Fix Entry points are not detected in Windows OS * Update changelog files * code refactoring * Let's update the changelog according to the npm publishing planned Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #38343, #38348
Description
The entry point is not detected and the build file is not generated on Windows OS when placing the JavaScript file that will be the entry point in a subfolder.
I fixed that problem in this PR.
It would be great if you could test it on Windows OS and Mac OS, if you like.
Testing Instructions
Check out this branch.
Run create-block without installing wp-scirpts.
(I added some PHP files to to test the copy of the PHP files as well)
startorbuildcommand to generate assets.Build result before fix
The
block.jsonand PHP files will be copied, but the JavaScript will not be built.Also
index.assets.phpwas not generated.You will also see the following message, indicating that the entry point was not detected.
808c1bd7ae7bf03b60d23b030b8973fe.mp4
Build result after fix
All assets should be generated correctly as shown below with this fix.
Types of changes
gutenberg/packages/scripts/utils/config.js
Lines 231 to 241 in c034da1
At this point, the path separator for
entryNamewill be a backslash.Therefore, the regular expression string in the
globfor detectingentryFilePathwill be replaced by a string with different delimiters mixed in, as followsAs described in the v3.0.0 release notes, I think the reason is that only forward slashes are allowed in regular expressions in globs, and slash replacement is no longer processed.
I was a little confused about how to write it, I simply added a process to replace the regular expression string with a forward slash to minimize the scope of the impact.)
Checklist:
*.native.jsfiles for terms that need renaming or removal).