Fix: CSS files don't build in dev mode on Windows #42041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Jun 29, 2022
| path.resolve( PACKAGES_DIR, packageName, 'src/*.scss' ) | ||
| path | ||
| .resolve( PACKAGES_DIR, packageName, 'src/*.scss' ) | ||
| .replace( /\\/g, '/' ) | ||
| ); |
There was a problem hiding this comment.
I discovered that when I run npm run dev, createStyleEntryTransform function is executed and the CSS file stored in this entries variable is returned to stream.
However, this variable was empty on Windows OS.
As described in the fast-glob v3.0.0 release notes, I think the reason is that only forward slashes are allowed in regular expressions in globs, and slash replacement is no longer processed.
So I added the process of replacing backslashes with forward slashes.
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Follow-up on:
What?
This PR resolves a problem in Windows OS where CSS files are not properly monitored and built when
npm run devis run.Why? & How?
See this comment.
Testing Instructions
npm run dev.packages/directory.(e.g.
packages\components\src\placeholder\style.scss)build/directory have been updated according to the SCSS update.(e.g.
build/components/style.css)