Scripts: Fallback to src/index.js when no valid scripts in metadata for build command
#38367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for `build` command
gziolo
added
[Package] Scripts
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
gziolo
added a commit
that referenced
this pull request
Jan 31, 2022
… for `build` command (#38367) * Scripts: Fallback to `src/index.js` when no valid scripts in metadata for `build` command * Scripts: Add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves #38357.
When testing the Superlist plugin with two blocks from @createwithrani I figured out that we don't have proper handling when there are no scripts in the
srcsubfolder discovered when scanning existingblock.jsonfiles. This PR ensures that thewp-scripts buildcommand falls back tosrc/index.jswhen that happens.Testing Instructions
You can use the Superlist plugin for testing however, you will need to remove the
webpack.config.jsfiles that override the entry points.The steps I used:
cd superlist.rm webpack.config.js.../node_modules/.bin/wp-scripts build.block.jsonfiles copied over, but also other files built fromsrc/index.js.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist:
*.native.jsfiles for terms that need renaming or removal).