Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @wordpress/scripts from 20.0.2 to 21.0.0 #662

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 11, 2022

Bumps @wordpress/scripts from 20.0.2 to 21.0.0.

Changelog

Sourced from @​wordpress/scripts's changelog.

21.0.0 (2022-02-10)

Breaking Changes

  • The bundled puppeteer-core dependency has been updated from requiring ^11.0.0 to requiring ^13.2.0 (#37078).
Commits
  • 2e49228 chore(release): publish
  • 99da143 Update changelog files
  • 8ae7eb7 Merge changes published in the Gutenberg plugin "release/12.6" branch
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 11, 2022 01:38
@dependabot dependabot bot added Component: Dependencies Pull requests that update a dependency file Component: JavaScript Pull requests that update Javascript code labels Feb 11, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/wordpress/scripts-21.0.0 branch 3 times, most recently from d8dbbd4 to 1c6d84a Compare February 11, 2022 02:12
Bumps [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts) from 20.0.2 to 21.0.0.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/scripts@21.0.0/packages/scripts)

---
updated-dependencies:
- dependency-name: "@wordpress/scripts"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/wordpress/scripts-21.0.0 branch from 1c6d84a to b302f71 Compare February 11, 2022 02:22
@jblz
Copy link
Contributor

jblz commented Feb 11, 2022

I think this was broken by WordPress/gutenberg#38367

Adding an empty src/index.js allows our webpack config to be sourced as before.

Without it, calling getWebpackEntryPoints() via node_modules/@wordpress/scripts/config/webpack.config.js ends up not applying our entry settings.

Copy link
Contributor

@jblz jblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can change this around to avoid having to have an empty src/index.js file.

@pauarge pauarge added this to the 3.2.0 milestone Feb 11, 2022
@pauarge
Copy link
Contributor

pauarge commented Feb 11, 2022

@jblz This is a bug on their end, it looks like they already have a PR to fix it: WordPress/gutenberg#38737

@jblz
Copy link
Contributor

jblz commented Feb 11, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 11, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jblz
Copy link
Contributor

jblz commented Feb 11, 2022

@dependabot recreate

@jblz jblz self-requested a review February 11, 2022 14:01
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 11, 2022

Superseded by #664.

@dependabot dependabot bot closed this Feb 11, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/wordpress/scripts-21.0.0 branch February 11, 2022 14:01
@pauarge pauarge removed this from the 3.2.0 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Dependencies Pull requests that update a dependency file Component: JavaScript Pull requests that update Javascript code Status: Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants