Site Editor: Set the <title> on the list page to be same as the CPT name #36805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
Backport to WP Beta/RC
38 tasks
Mamaduka
reviewed
Nov 24, 2021
| } | ||
| } | ||
| } | ||
| add_action( 'load-appearance_page_gutenberg-edit-site', 'gutenberg_set_site_editor_list_page_title' ); |
There was a problem hiding this comment.
Any reason for not using the admin_title filter - https://developer.wordpress.org/reference/hooks/admin_title/?
There was a problem hiding this comment.
I wanted to write this in a way that's pretty close to how it will look when added to Core, which is that we'll just change $title here:
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
added a commit
that referenced
this pull request
Nov 29, 2021
…ame (#36805) * Site Editor: Set the <title> on the list page to be same as the CPT name * Remove unused argument
|
Is this code still required now that we moved to frontend routing? |
|
@youknowriad, it's not. We handle document title update on the client-side now. |
|
We should be able to just revert this. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #36597.
Changes the
<title>on the list page to be the name of the CPT being edited, e.g. 'Templates'.How has this been tested?
Screenshots
Checklist:
*.native.jsfiles for terms that need renaming or removal).