Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Site Editor: Set the <title> on the list page to be same as the CPT name" #37270

Merged
merged 1 commit into from Dec 10, 2021
Merged

Revert "Site Editor: Set the <title> on the list page to be same as the CPT name" #37270

merged 1 commit into from Dec 10, 2021

Conversation

noisysocks
Copy link
Member

Reverts #36805

As @youknowriad notes in #36805 (comment), this isn't necessary now that this screen uses client side routing.

To test:

  1. Open the site editor.
  2. Open the W menu.
  3. Browse to Templates or Template Parts.
  4. Notice that the window title is Templates or Template Parts.

@noisysocks noisysocks added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Dec 10, 2021
Mamaduka
Mamaduka approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noisysocks noisysocks merged commit 8325a80 into trunk Dec 10, 2021
@noisysocks noisysocks deleted the revert-36805-fix/title-on-site-editor-list-page branch December 10, 2021 05:36
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 10, 2021
@noisysocks noisysocks removed the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 13, 2021
noisysocks added a commit that referenced this pull request Dec 13, 2021
@noisysocks
Revert "Site Editor: Set the <title> on the list page to be same as t…
2d48c46 
…he CPT name (#36805)" (#37270)

This reverts commit 8113d35.
@noisysocks noisysocks mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 12.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noisysocks @Mamaduka