Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wide + full support to the site tagline block #35589

Merged
merged 1 commit into from Oct 13, 2021

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Oct 13, 2021

This PR adds wide and full alignment support to the Site Tagline block, to bring it in sync with the Site Title block.

I can't think of a great reason not to have feature parity between these two blocks. Besides, the designs for Twenty Twenty-Two feature a wide site tagline, and this allows us to achieve that without an extra columns block wrapper hack:

Screen Shot 2021-10-13 at 7 55 23 AM

Before After
Screen Shot 2021-10-13 at 7 57 26 AM Screen Shot 2021-10-13 at 7 53 10 AM

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Block] Site Tagline Affects the Site Tagline Block labels Oct 13, 2021
@kjellr kjellr self-assigned this Oct 13, 2021
@kjellr kjellr requested a review from jffng October 13, 2021 12:01
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjellr kjellr merged commit bccecb5 into trunk Oct 13, 2021
@kjellr kjellr deleted the add/alignments-to-site-tagline branch October 13, 2021 12:45
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Tagline Affects the Site Tagline Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants