This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Simplify dark header template and pattern. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
jffng
reviewed
Oct 13, 2021
inc/patterns/header-large-dark.php
Outdated
|
|
||
| <!-- wp:site-title {"style":{"typography":{"fontStyle":"italic","fontWeight":"400"}}} /--></div> | ||
| <!-- /wp:group --> | ||
|
|
||
| <!-- wp:navigation {"itemsJustification":"right","isResponsive":true} --> | ||
| <!-- wp:navigation {"itemsJustification":"right"} --> |
There was a problem hiding this comment.
Did you mean to remove the isResponsive attribute?
There was a problem hiding this comment.
I did not! Weird. I'll put it back in.
jffng
approved these changes
Oct 13, 2021
kjellr
commented
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the block setup for the Dark header template and pattern (used on the homepage).
When testing, you'll need to be running the latest Gutenberg
trunk. (If it works, I think it's fine to merge this in now, even though that change hasn't made it to the plugin yet).