[Block: Post comment date]: Add link setting and block supports #35112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5.63 kB (+1%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
carolinan
added
the
[Block] Comments
|
Thanks for the Pull Request! 🙂 @gziolo I'm afraid I don't feel comfortable yet reviewing the code, could you take a look at it, please? |
gziolo
reviewed
Oct 7, 2021
There was a problem hiding this comment.
I'm afraid I don't feel comfortable yet reviewing the code, could you take a look at it, please?
No worries @SantosGuillamot. The code looks good. I haven't tested so I would appreciate some help on that front.
| if ( isLink ) { | ||
| commentDate = ( | ||
| <a | ||
| href="#comment-date-pseudo-link" |
There was a problem hiding this comment.
Could we use an actual link here? In PHP it's possible with get_comment_link( $block->context['commentId'] );. Would it work with useEntityProp( 'root', 'comment', 'link', commentId ) or something like that?
There was a problem hiding this comment.
Do we really want it to be clickable in the editor? Is the issue where duplicate editors were opened fixed?
There was a problem hiding this comment.
I mean we have used fake links because the editor would be opened inside the editor.
There was a problem hiding this comment.
We use real links in RichText:
I wasn't aware of a limitation like that. I see more places where the same pattern is used so it's probably fine to leave it as is for now.
gziolo
approved these changes
Oct 7, 2021
Closed
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
This was referenced Oct 15, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #30573.
How has this been tested?
datetimeattribute and in the text.Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).