Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Date Block #30573

Closed
jameskoster opened this issue Apr 7, 2021 · 11 comments · Fixed by #35112
Closed

Comment Date Block #30573

jameskoster opened this issue Apr 7, 2021 · 11 comments · Fixed by #35112
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block

Comments

@jameskoster
Copy link
Contributor

Here is an initial take on the design for the Comment Date block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).

comment-date

Design feedback is politely requested for all aspects:

  • Icon
  • Placeholder when there is no context present
  • Toolbar actions
  • Inspector settings
  • Name
  • Description

Figma link here.

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 7, 2021
@jameskoster jameskoster added [Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Apr 7, 2021
@annezazu
Copy link
Contributor

annezazu commented Apr 7, 2021

@jameskoster thanks so much for this exploration! While you're exploring this, I wanted to loop in some feedback that came out of a stream from a contributor where she mentioned that the date selection is currently unstyled:

Screen Shot 2021-04-07 at 11 06 17 AM

Is this something you plan to address here? I wasn't able to see it in the figma file so wanted to check to be sure.

@jameskoster
Copy link
Contributor Author

@annezazu I think that is a separate issue altogether. Looks like a bug in the Post Date block.

@annezazu
Copy link
Contributor

annezazu commented Apr 7, 2021

Facepalm -- got my date blocks confused. Thank you. Sorry about that!

@paaljoachim
Copy link
Contributor

Hi James

It looks like you have the added options needed for this block.
One thing. I assume it will use the same date style as the rest of the WP backend.
As the date will change depending on the WP settings date and time settings.

@jameskoster
Copy link
Contributor Author

I assume it will use the same date style as the rest of the WP backend.

Yup, the date format option should be respected here. But as in the Post Date block, it should be customisable:

Screenshot 2021-04-21 at 09 43 24

@carolinan
Copy link
Contributor

The first iteration of this block as "Post Comment Date" was added in #24854

@carolinan carolinan added the [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop label May 7, 2021
@justintadlock
Copy link
Contributor

Noting that a common use case for the comment published date is to wrap it in the permalink for the comment. Maybe a "link to comment" would make for a good option.

@SantosGuillamot
Copy link
Contributor

SantosGuillamot commented Sep 21, 2021

Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one:

Description

Add the date of the specific comment.

Potential Settings

  • Typography: It should be the same as the Post Date Block.
  • Color Settings: It should be the same as the Post Date Block.
  • Format Settings: It should be the same as the Post Date Block.
  • Link Settings:
    • Link to comment: Clicking the date will take the user to the comment URL.

References

Of course, any feedback is welcome 🙂

@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@SantosGuillamot SantosGuillamot added New Block Suggestion for a new block and removed Needs Design Feedback Needs general design feedback. labels Sep 21, 2021
@carolinan carolinan moved this from To do to In progress in Comments Loop block Sep 24, 2021
@gziolo
Copy link
Member

gziolo commented Oct 7, 2021

I see that #35112 for Link Settings is close to ready. @carolinan, do you plan to continue working on other enhancements that @SantosGuillamot proposed?

@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Oct 7, 2021
@carolinan
Copy link
Contributor

After #35112 there is nothing left to do on the checklist. I only mentioned that it was a partial pull request because it can't be tested inside a comment template /comment loop yet.

@gziolo
Copy link
Member

gziolo commented Oct 7, 2021

That's awesome. Thank you for the clarification @carolinan. Let's close this issue once #35112 land then 😄

I wasn't aware that other features require only feature toggles. As simple as that 🎉

Comments Loop block automation moved this from In progress to Done Oct 7, 2021
@SantosGuillamot SantosGuillamot removed the [Status] In Progress Tracking issues with work in progress label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants