Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Template block #35000

Closed
SantosGuillamot opened this issue Sep 21, 2021 · 3 comments · Fixed by #35231
Closed

Comments Template block #35000

SantosGuillamot opened this issue Sep 21, 2021 · 3 comments · Fixed by #35231
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@SantosGuillamot
Copy link
Contributor

Description

Contains the block elements used to render a comment, like the content, date, or author for example. This should be similar to the Post Template block.

This block is part of the Post Comments Loop block, for more context please visit this Tracking Issue or its GitHub project.

Potential Settings

The settings should be the same as the Post Template block.

Requirements

This block should only be available inside the Post Comments Query Loop Block.

References

@SantosGuillamot SantosGuillamot added [Feature] Blocks Overall functionality of blocks [Feature] Full Site Editing [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Sep 21, 2021
@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@SantosGuillamot SantosGuillamot added the New Block Suggestion for a new block label Sep 21, 2021
@SantosGuillamot SantosGuillamot changed the title Post Comments Template block Comments Template block Oct 8, 2021
@michalczaplinski
Copy link
Contributor

A stub of this block is created in the #35231 PR.

@gziolo gziolo moved this from To do to In progress in Comments Loop block Oct 19, 2021
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Oct 19, 2021
@SantosGuillamot
Copy link
Contributor Author

As mentioned in this Pull Request and this related issue, we should consider how to handle when comments are closed in a post. If I understood it correctly:

  • We should show a "Comments are closed" message if comments have been opened previously.
  • We shouldn't show a "Comments are closed" message if comments haven't been opened previously. We could even include a setting to hide/show this message.

@gziolo
Copy link
Member

gziolo commented Oct 21, 2021

Nit: I think that the name of the block should be Comment Template block to align with Post Template block. There is a plural form "Comments" in the title. It looks like we should have all blocks necessary for the template ready quite soon. Some blocks landed/were updated recently, the remaining are in progress but in very advanced stage.

@gziolo gziolo moved this from In progress to In review in Comments Loop block Oct 27, 2021
Comments Loop block automation moved this from In review to Done Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants