Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSC] Rename Array#groupBy to Array#group and enable them #2990

Commits on Aug 4, 2022

  1. [JSC] Rename Array#groupBy to Array#group and enable them

    https://bugs.webkit.org/show_bug.cgi?id=243510
    
    Reviewed by Mark Lam, Justin Michaud, Devin Rousso and Ross Kirsling.
    
    We agreed at TC39 to renaming Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap
    to keep web-compatibility. This patch renames and enables them, stage-4 progress is tracked in [1].
    We also upstreamed test262 fix for this[2].
    
    [1]: tc39/proposal-array-grouping#32
    [2]: tc39/test262#3632
    
    * Source/JavaScriptCore/builtins/ArrayPrototype.js:
    (group):
    (groupToMap):
    (groupBy): Deleted.
    (groupByToMap): Deleted.
    * Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
    (JSC::ArrayPrototype::finishCreation):
    * Source/JavaScriptCore/runtime/OptionsList.h:
    
    Canonical link: https://commits.webkit.org/253101@main
    Constellation committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    317e700 View commit details
    Browse the repository at this point in the history