[JSC] Rename Array#groupBy to Array#group and enable them #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
JavaScriptCore
Constellation
force-pushed
the
eng/JSC-Rename-ArraygroupBy-to-Arraygroup-and-enable-them
branch
from
6b2ba67
to
330465b
Compare
justinmichaud
approved these changes
Aug 3, 2022
| @@ -541,7 +541,7 @@ bool canUseWebAssemblyFastMemory(); | |||
| /* Feature Flags */\ | |||
| \ | |||
| v(Bool, useArrayFindLastMethod, true, Normal, "Expose the findLast() and findLastIndex() methods on Array and %TypedArray%.") \ | |||
| v(Bool, useArrayGroupByMethod, false, Normal, "Expose the groupBy() and groupByToMap() methods on Array.") \ | |||
| v(Bool, useArrayGroupMethod, true, Normal, "Expose the group() and groupToMap() methods on Array.") \ | |||
There was a problem hiding this comment.
We enable this by default?
There was a problem hiding this comment.
Yes, this patch enables it.
Constellation
force-pushed
the
eng/JSC-Rename-ArraygroupBy-to-Arraygroup-and-enable-them
branch
from
330465b
to
a046d9f
Compare
dcrousso
approved these changes
Aug 3, 2022
Constellation
force-pushed
the
eng/JSC-Rename-ArraygroupBy-to-Arraygroup-and-enable-them
branch
from
a046d9f
to
c555596
Compare
webkit-early-warning-system
added
the
merging-blocked
Constellation
removed
the
merging-blocked
Constellation
force-pushed
the
eng/JSC-Rename-ArraygroupBy-to-Arraygroup-and-enable-them
branch
from
c555596
to
793f554
Compare
https://bugs.webkit.org/show_bug.cgi?id=243510 Reviewed by Mark Lam, Justin Michaud, Devin Rousso and Ross Kirsling. We agreed at TC39 to renaming Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap to keep web-compatibility. This patch renames and enables them, stage-4 progress is tracked in [1]. We also upstreamed test262 fix for this[2]. [1]: tc39/proposal-array-grouping#32 [2]: tc39/test262#3632 * Source/JavaScriptCore/builtins/ArrayPrototype.js: (group): (groupToMap): (groupBy): Deleted. (groupByToMap): Deleted. * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::finishCreation): * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/253101@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Rename-ArraygroupBy-to-Arraygroup-and-enable-them
branch
from
793f554
to
317e700
Compare
|
Committed 253101@main (317e700): https://commits.webkit.org/253101@main Reviewed commits have been landed. Closing PR #2990 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
317e700