Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tcp feature to hyper #77

Merged
merged 1 commit into from Apr 17, 2024

Conversation

threema-donat
Copy link
Contributor

Prevents executor must be set panic when hyper with tcp enabled is not already in the dependencies of the project.

Description

  • Add tcp feature to hyper

I suggest to release a new version once this is merged since a2 cannot work for anybody not having hyper ^0.14 with tcp feat enabled in the dependencies.

Resolves #76

How Has This Been Tested?

Used this as a path dependency in this project

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Prevents `executor must be set` panic when hyper with tcp enabled is not already in the dependencies of the project
@link2xt
Copy link

link2xt commented Apr 14, 2024

Also hyper itself should be updated: #75

@link2xt
Copy link

link2xt commented Apr 14, 2024

cc @HarryET because they are not watching the repo

@HarryET
Copy link
Contributor

HarryET commented Apr 16, 2024

cc @HarryET because they are not watching the repo

I'm no longer a member of the company so sadly my ability to merge the PR isn't there anymore. I'll ping someone there and see if they can review and/or take the repo back.

\cc @chris13524

@chris13524
Copy link
Member

Thanks for the ping @HarryET! This repo wasn't being watched but now it is.

@threema-donat can you rebase on #75 ?

@chris13524 chris13524 self-assigned this Apr 16, 2024
@threema-donat
Copy link
Contributor Author

threema-donat commented Apr 17, 2024

I would suggest to merge this first and then do a release (e.g. as version 0.8.1) before merging #75 for two reasons:

  • This release should not break any existing applications and can be released as a patch version
  • People that do not want to upgrade to hyper v1 right now can continue using this version until they are ready to upgrade

@chris13524 chris13524 merged commit ce701eb into WalletConnect:master Apr 17, 2024
5 checks passed
@chris13524 chris13524 mentioned this pull request Apr 17, 2024
3 tasks
@threema-donat
Copy link
Contributor Author

@chris13524 Thank you for merging this! I realized that you have created the GitHub release for 0.8.1, but not published yet on crates.io.
I guess you might have forgotten to publish it; would you be so kind and publish it?

@chris13524
Copy link
Member

Yeh @threema-donat yes sorry, working on the publish. Need to transfer from original owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic executor must be set occurs when hyper dep with "tcp" feat enabled is not in dependencies
4 participants