Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to hyper 1.0 #75

Merged
merged 4 commits into from Apr 25, 2024
Merged

chore: upgrade to hyper 1.0 #75

merged 4 commits into from Apr 25, 2024

Conversation

boxdot
Copy link
Contributor

@boxdot boxdot commented Mar 25, 2024

Description

Also remove the dependency on hyper-alpn. There is no need for this dependency since all its features are already implemented in hyper-rustls.

Upgrade to remove duplicated dependencies:

  • base64 from 0.21 -> 0.22
  • pem 1.0 -> 3.0
  • ring 0.16 -> 0.17

How Has This Been Tested?

  • Tested manually with the token example

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@boxdot
chore: upgrade to hyper 1.0
34150cd 
Also remove the dependency on hyper-alpn. There is no need for this
dependency since all its features are already implemented in
hyper-rustls.

Upgrade to remove duplicated dependencies:
* base64 from 0.21 -> 0.22
* pem 1.0 -> 3.0
* ring 0.16 -> 0.17
@boxdot
remove commented out dep
93c51ac
@boxdot
fix ring feature
2262258
@link2xt link2xt mentioned this pull request Apr 14, 2024
Merged
3 tasks
chris13524
chris13524 previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Sorry about the delay, this repo wasn't being watched but now it is.

geekbrother
geekbrother previously approved these changes Apr 16, 2024
View reviewed changes
Copy link

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@chris13524 chris13524 self-assigned this Apr 16, 2024
@chris13524
Copy link
Member

chris13524 commented Apr 17, 2024 •
edited

Hey @boxdot can you resolve merge conflicts? 🙏 Looks like you just need to add tcp feature to hyper dependency which was introduced by #77. Didn't want to commit to your master branch

@boxdot
Copy link
Contributor Author

boxdot commented Apr 17, 2024 via email •
edited

@boxdot boxdot dismissed stale reviews from geekbrother and chris13524 via 76891b2 April 22, 2024 08:09
@boxdot
Copy link
Contributor Author

boxdot commented Apr 22, 2024

Sure. I do it today in the evening. Thanks for telling.

Sometimes "in the evening" means "one week later". Sorry about that.

chris13524
chris13524 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chris13524 chris13524 merged commit 2395a40 into WalletConnect:master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@geekbrother geekbrother geekbrother left review comments

@nopestack nopestack Awaiting requested review from nopestack

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boxdot @chris13524 @geekbrother