Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Allow protobuf < 4.0 to support M1 Macs #3070

Merged
merged 3 commits into from Jul 29, 2022
Merged

chore: Allow protobuf < 4.0 to support M1 Macs #3070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6769327
chore: Allow protobug < 4.0
liuverta Jul 27, 2022
3d197eb
Remove no-space-check
liuverta Jul 28, 2022
38569db
Ignore protobuf.struct_pb2 in pylint
liuverta Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 2 additions & 8 deletions client/verta/.pylintrc
View file
Open in desktop
Expand Up @@ -285,7 +285,8 @@ ignored-classes=optparse.Values,
# (useful for modules/projects where namespaces are manipulated during runtime
# and thus existing member attributes cannot be deduced by static analysis. It
# supports qualified module names, as well as Unix pattern matching.
ignored-modules=verta._protos.*
ignored-modules=verta._protos.*,
google.protobuf.struct_pb2,
Copy link
Contributor Author

@liuverta liuverta Jul 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf==3.20 deepens its dynamic generation shenanigans

Protobuf python generated codes are simplified. Descriptors and message classes' definitions are now dynamic created in internal/builder.py.

which causes pylint check failures, unless explicitly ignored here.


# Show a hint with possible names when a member name was not found. The aspect
# of finding the hint is based on edit distance.
Expand Down Expand Up @@ -351,13 +352,6 @@ max-line-length=100
# Maximum number of lines in a module
max-module-lines=1000

# List of optional constructs for which whitespace checking is disabled. `dict-
# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}.
# `trailing-comma` allows a space between comma and closing bracket: (a, ).
# `empty-line` allows space-only lines.
no-space-check=trailing-comma,
dict-separator

Comment on lines -354 to -360
Copy link
Contributor Author

@liuverta liuverta Jul 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed in pylint==2.6, and pylint==2.14 starts raising an exception for unrecognized options.

# Allow the body of a class to be on the same line as the declaration if body
# contains single statement.
single-line-class-stmt=no
Expand Down
2 changes: 1 addition & 1 deletion client/verta/requirements.txt
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@ click >= 7.0, < 9.0
cloudpickle ~= 1.0
googleapis-common-protos >= 1.5, < 2.0
pathlib2 >= 2.2, < 3.0
protobuf >= 3.8, < 3.18
protobuf >= 3.8, < 4.0
pytimeparse >= 1.1.8, < 2.0
pyyaml >= 5.1, < 6.0
requests >= 2.21, < 3.0