New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Allow protobuf < 4.0 to support M1 Macs #3070
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -285,7 +285,8 @@ ignored-classes=optparse.Values, | |
# (useful for modules/projects where namespaces are manipulated during runtime | ||
# and thus existing member attributes cannot be deduced by static analysis. It | ||
# supports qualified module names, as well as Unix pattern matching. | ||
ignored-modules=verta._protos.* | ||
ignored-modules=verta._protos.*, | ||
google.protobuf.struct_pb2, | ||
|
||
# Show a hint with possible names when a member name was not found. The aspect | ||
# of finding the hint is based on edit distance. | ||
|
@@ -351,13 +352,6 @@ max-line-length=100 | |
# Maximum number of lines in a module | ||
max-module-lines=1000 | ||
|
||
# List of optional constructs for which whitespace checking is disabled. `dict- | ||
# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}. | ||
# `trailing-comma` allows a space between comma and closing bracket: (a, ). | ||
# `empty-line` allows space-only lines. | ||
no-space-check=trailing-comma, | ||
dict-separator | ||
|
||
Comment on lines
-354
to
-360
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
# Allow the body of a class to be on the same line as the declaration if body | ||
# contains single statement. | ||
single-line-class-stmt=no | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protobuf==3.20
deepens its dynamic generation shenaniganswhich causes
pylint
check failures, unless explicitly ignored here.