Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2: Upgrade standard and parser to avoid parser warning #1537

Merged
merged 2 commits into from Jan 20, 2022
Merged

2: Upgrade standard and parser to avoid parser warning #1537

merged 2 commits into from Jan 20, 2022

Commits on Jan 19, 2022

  1. Upgrade standard to fix parser warning 

    This is the result of pinning parser to ~> 3.0.1.0 (or a 2.7.3
compatible) and `bundle update standard`.

We were on a very old 0.1.8 standard and we can only get to 1.5.0
without warnings by moving parser on to the version that handles 2.7.3.

A simpler thing would be to bump the .ruby-version to 2.7.5 but since
this requires lengthy installs on all incoming dev boxes, we can put
that off for the moment.
    @rgarner
    rgarner committed Jan 19, 2022
    Copy the full SHA
    4f1ffed View commit details
    Browse the repository at this point in the history

  2. Fix all the 1.5.0 standard.rb errors 

    Going from 0.1.8 to 1.5.0 produces a slew of errors due to breaking
changes in style – mostly commas on the last elements in arrays. A
couple of "don't define constants in blocks this way" which are bobbins
in specs and we can ignore with standard:disable.
    @rgarner
    rgarner committed Jan 19, 2022
    Copy the full SHA
    b8f9589 View commit details
    Browse the repository at this point in the history