2: Upgrade standard and parser to avoid parser warning #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of pinning parser to ~> 3.0.1.0 (or a 2.7.3 compatible) and `bundle update standard`. We were on a very old 0.1.8 standard and we can only get to 1.5.0 without warnings by moving parser on to the version that handles 2.7.3. A simpler thing would be to bump the .ruby-version to 2.7.5 but since this requires lengthy installs on all incoming dev boxes, we can put that off for the moment.
Going from 0.1.8 to 1.5.0 produces a slew of errors due to breaking changes in style – mostly commas on the last elements in arrays. A couple of "don't define constants in blocks this way" which are bobbins in specs and we can ignore with standard:disable.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Upgrade from very old
0.1.8standardto1.5.0. We were manually pinningparserto~> 2.6.3.0and that was generating the parser warning on the beginning of every test suite.Avoid bumping Ruby to 2.7.5 right this second; this will make the job a bit easier when we come to do it. Acknowledge that pinning
parserhas the effect of potentially generating the parser warning whenever we upgrade Ruby (although Rubocop has since been patched to silence the warning so will no longer be a source), and we'll need to manually move it along in the Gemfile when we do so.See rubocop/rubocop#9700 (comment) for details
Next steps
CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.