Fix ConcurrentModificationException when iterating through connection #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s returned by getConnections()
marci4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ConcurrentModificationException when iterating through connections returned by getConnections()
Description
Wrap new ArrayList(connections) in synchronized to avoid ConcurrentModificationException
Related Issue
Issue #921
Also related to #902
Motivation and Context
ConcurrentModificationException when looping connections and a connection is created/removed elsewhere at the same time.
How Has This Been Tested?
Tested in production with a tight loop iterating over connections gathering statistics whilst connections are made/removed elsewhere. No more cases of ConcurrentModificationException after the fix.
Types of changes
Checklist: