java.util.ConcurrentModificationException on broadcast

[papirosko]

Hi. Broadcasting uses connections without synchronization:

	/**
	 * Send a text to all connected endpoints
	 * @param text the text to send to the endpoints
	 */
	public void broadcast(String text) {
		broadcast( text, connections );
	}

even trying to override this method with:

  override void broadcast(String: text) = {
    broadcast( text, getConnections() );
  }

will lead to

java.util.ConcurrentModificationException: null
	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)
	at java.util.HashMap$KeyIterator.next(HashMap.java:1469)
	at java.util.AbstractCollection.toArray(AbstractCollection.java:141)
	at java.util.ArrayList.<init>(ArrayList.java:178)
	at org.java_websocket.server.WebSocketServer.getConnections(WebSocketServer.java:282)

[papirosko]

as a workaround, use new CopyOnWriteArraySet() in websocket constructor.

[izamata01]

can you guys help me get my mobile back in my control. someone is redirecting me. My phone company have no idea. Customer service is all i get.Its almost like someones cloned my phone. cloned my phone. Plz help me. im not a developer im just reaching out for help

…

On Tue, Jan 7, 2020 at 10:23 PM Vladimir Penkov ***@***.***> wrote: Hi. Broadcasting uses connections without synchronization: /** * Send a text to all connected endpoints * @param text the text to send to the endpoints */ public void broadcast(String text) { broadcast( text, connections ); } even trying to override this method with: override void broadcast(String: text) = { broadcast( text, getConnections() ); } will lead to java.util.ConcurrentModificationException: null at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445) at java.util.HashMap$KeyIterator.next(HashMap.java:1469) at java.util.AbstractCollection.toArray(AbstractCollection.java:141) at java.util.ArrayList.<init>(ArrayList.java:178) at org.java_websocket.server.WebSocketServer.getConnections(WebSocketServer.java:282) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#961?email_source=notifications&email_token=AOEUENP44GX4FT7Y4EB5WB3Q4VIK7A5CNFSM4KECTJZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEVARRQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOEUENKVCTZGB4ABBP7A433Q4VIK7ANCNFSM4KECTJZQ> .

[marci4]

Hello,
Could you try the latest snapshot?
Should be fixed with #922.

Best regards,
Marcel

[marci4]

Closing this issue as duplicate!

Best regards,
Marcel