Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused height parameter from Layout class #2540

Merged
merged 2 commits into from Sep 23, 2022
Merged

Remove unused height parameter from Layout class #2540

merged 2 commits into from Sep 23, 2022

Conversation

darrenburns
Copy link
Member

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

The height parameter wasn't used.

@darrenburns darrenburns linked an issue Sep 23, 2022 that may be closed by this pull request
[BUG] Height parameter in Layout is not used #2518
Closed
@darrenburns darrenburns merged commit 28a05fa into master Sep 23, 2022
@darrenburns darrenburns deleted the remove-layout-height-param-unused branch September 23, 2022 12:09
@iloveitaly iloveitaly mentioned this pull request Oct 11, 2022
Merged
@iloveitaly iloveitaly mentioned this pull request Jan 2, 2023
Merged
@linear linear bot mentioned this pull request Jan 2, 2023
Closed
@linear linear bot mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Height parameter in Layout is not used
2 participants
@darrenburns @willmcgugan