Skip to content

Commit

Permalink
Remove unused height parameter from Layout class (#2540)
Browse files Browse the repository at this point in the history
* Remove unused height parameter from Layout class

* Update CHANGELOG.md
  • Loading branch information
darrenburns committed Sep 23, 2022
1 parent 4200f51 commit 28a05fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix NO_COLOR support on legacy Windows https://github.com/Textualize/rich/pull/2458
- Fix pretty printer handling of cyclic references https://github.com/Textualize/rich/pull/2524
- Fix missing `mode` property on file wrapper breaking uploads via `requests` https://github.com/Textualize/rich/pull/2495
- Remove unused height parameter in `Layout` class https://github.com/Textualize/rich/pull/2540

### Changed

Expand Down
4 changes: 1 addition & 3 deletions rich/layout.py
Expand Up @@ -20,8 +20,8 @@
from .highlighter import ReprHighlighter
from .panel import Panel
from .pretty import Pretty
from .repr import rich_repr, Result
from .region import Region
from .repr import Result, rich_repr
from .segment import Segment
from .style import StyleType

Expand Down Expand Up @@ -162,15 +162,13 @@ def __init__(
minimum_size: int = 1,
ratio: int = 1,
visible: bool = True,
height: Optional[int] = None,
) -> None:
self._renderable = renderable or _Placeholder(self)
self.size = size
self.minimum_size = minimum_size
self.ratio = ratio
self.name = name
self.visible = visible
self.height = height
self.splitter: Splitter = self.splitters["column"]()
self._children: List[Layout] = []
self._render_map: RenderMap = {}
Expand Down

0 comments on commit 28a05fa

Please sign in to comment.