Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out-of-bounds read in document.h #7

Closed
wants to merge 1 commit into from
Closed

Fix out-of-bounds read in document.h #7

wants to merge 1 commit into from

Commits on Jun 17, 2014

  1. Fix out-of-bounds read in document.h 

    FindMember() compares length of "name" and "member->name.data_.s" via "name[member->name.data_.s.length] == '\0'", which can lead to reading past the length of "name". This patch stores the length of "name" (as determined by position of '\0') into "name_length" and changes the length comparison to be "name_length == "member->name.data_.s.length".
    @rsolomakhin
    rsolomakhin committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    2e8efad View commit details
    Browse the repository at this point in the history