Fix out-of-bounds read in document.h #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindMember() compares length of "name" and "member->name.data_.s" via "name[member->name.data_.s.length] == '\0'", which can lead to reading past the length of "name". This patch stores the length of "name" (as determined by position of '\0') into "name_length" and changes the length comparison to be "name_length == "member->name.data_.s.length".
|
This has been reported as upstream issue 108 and a fix similar to yours is part of my Compared to the fix in pah/rapidjson@f86af8c2, your patch does not handle different character types. You should use the |
|
Yes, your fix is better. I see that you've started to work with the developer in #1. I will close this pull request and issue and look forward to your patch being accepted. Good luck! |
miloyip
added a commit
that referenced
this pull request
Jun 20, 2014
The original FindMember() may access out-of-bound of the 'const char* name' parameter. This commit firstly follows pah/rapidjson@f86af8c However, this must incur an StrLen() for name. A better API is by using Value as the name, which provides the length of string internally. So a set of new API are added: operator[](const GenericValue& name) FindMember(const GenericValue& name) RemoveMember(const GenericValue& name) During refactoring, it also adds an API: RemoveMember(MemberIterator m) which can be used for other purpose, such as removing a member while iterating an object. Fixes #7
Closed
This was referenced May 16, 2017
Closed
Open
This was referenced Jan 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindMember() compares length of "name" and "member->name.data_.s" via "name[member->name.data_.s.length] == '\0'", which can lead to reading past the length of "name". This patch stores the length of "name" (as determined by position of '\0') into "name_length" and changes the length comparison to be "name_length == "member->name.data_.s.length".