Update to pytest 5.4.0 API #188

GuillaumeFavelier · 2020-03-13T09:59:30Z

This PR uses self.write() instead of self.writer.write() to follow new pytest 5.4.0 API and avoid using self.writer directly which has been deprecated.

Closes #187

GuillaumeFavelier · 2020-03-13T10:04:56Z

Half of the CI jobs have an issue with convert, any idea how to fix that @blueyed ?

GuillaumeFavelier · 2020-03-13T11:03:27Z

From what I found it could be related to versions of attrs

blueyed · 2020-03-13T11:42:45Z

@GuillaumeFavelier
Yes, IIRC attrs dropped that - it should be pinned for the affected pytest4X jobs I guess.
But It might also make sense to not test with anything before pytest 4.6 maybe?

As for this fix, it would be good to also add the current pytest to the matrix.

codecov-io · 2020-03-13T16:20:53Z

Codecov Report

Merging #188 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   86.01%   86.19%   +0.17%     
==========================================
  Files           2        2              
  Lines         479      478       -1     
  Branches       85       85              
==========================================
  Hits          412      412              
  Misses         40       40              
+ Partials       27       26       -1

Impacted Files	Coverage Δ
test_sugar.py	`97.81% <100%> (ø)`	⬆️
pytest_sugar.py	`81.52% <100%> (+0.23%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f6d9f...b56fed4. Read the comment docs.

GuillaumeFavelier · 2020-03-13T16:22:26Z

I'm not familiar with tox so I tried something in eb91cdc

By the way, another version of pytest is out: 5.4.1

GuillaumeFavelier · 2020-03-13T17:11:32Z

Finally! This is ready to go I think 👍 @blueyed

I learned a bit about tox along the way 😅

GuillaumeFavelier · 2020-03-13T17:22:30Z

Pinging @Teemu as well

See also: * Teemu/pytest-sugar#187 * Teemu/pytest-sugar#188

SVilgelm · 2020-03-15T16:54:17Z

Guys, thank you for the quick fix. When can we expect a new release?
@Teemu @blueyed ?

- Teemu/pytest-sugar#188 makes pytest-sugar compatible with pytest 5.4+ - pytest 5.4.0 flipped the signs for assert statement display, so this flips the string to match.

breneser · 2020-03-26T14:05:45Z

Is this going to be merged in soon? Or is it best to switch to pytest <5.4.0

blueyed · 2020-03-26T14:27:52Z

@breneser it also needs to be released.
You might want fixing it on pytest's end a try: pytest-dev/pytest#6951 (comment) - see https://github.com/blueyed/pytest/pull/290/files#diff-606d01f030119020f3e820547882b6b0R399-R416 for a patch, which you could use for a PR there.
Otherwise either use pytest-sugar from this branch / with this patch, pin pytest, or remove pytest-sugar temporarily.

truthdoug · 2020-03-27T15:17:39Z

This will work to get pytest-sugar working until this has merged:

pip install -e git+https://github.com/GuillaumeFavelier/pytest-sugar.git@b56fed42d5c3022ff507ab6ce81cda65a3a5f92a#egg=pytest-sugar

It simply installs the version from @GuillaumeFavelier's fork.

Refs: * Teemu/pytest-sugar#188 * pytest-dev/pytest#6931

Teemu · 2020-04-26T13:20:00Z

Thanks for the PR 🎉

Teemu · 2020-04-26T13:35:23Z

0.9.3 has been released

- Teemu/pytest-sugar#188 makes pytest-sugar compatible with pytest 5.4+ - pytest 5.4.0 flipped the signs for assert statement display, so this flips the string to match.

Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.3.5 to 5.4.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@5.3.5...5.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Update pytest and pytest-sugar, fix test for - Teemu/pytest-sugar#188 makes pytest-sugar compatible with pytest 5.4+ - pytest 5.4.0 flipped the signs for assert statement display, so this flips the string to match. Fix test_fastapi.sh permissions

Ref: Teemu/pytest-sugar#188 (comment)

Update to pytest 5.4.0 API

f35da61

TST: Pin attrs and add py54 testenv target

eb91cdc

GuillaumeFavelier added 5 commits March 13, 2020 17:28

Add pytest54 to the matrix

cb144cf

TST: Try with space separator

c5348d0

TST: Try another syntax and fix --doctest-modules

b6b1827

TST: Try another syntax with variable

e0f463d

TST: Try with env name

b56fed4

chris-allan added a commit to chris-allan/omero-web that referenced this pull request Mar 14, 2020

pytest-sugar not compatible with pytest 5.4.0+

44e1adf

See also: * Teemu/pytest-sugar#187 * Teemu/pytest-sugar#188

chris-allan mentioned this pull request Mar 14, 2020

pytest-sugar not compatible with pytest 5.4.0+ ome/omero-web#152

Merged

blueyed approved these changes Mar 15, 2020

View reviewed changes

blueyed assigned Teemu Mar 15, 2020

StephenBrown2 mentioned this pull request Mar 15, 2020

Fix for pytest 5.4.X pydantic/pydantic#1312

Merged

4 tasks

bluetech mentioned this pull request Mar 16, 2020

INTERNALERROR> AttributeError: can't set attribute with pytest 5.4.1 pytest-dev/pytest#6931

Closed

2 tasks

WolfgangFellger mentioned this pull request Mar 26, 2020

pytest-sugar is not working with pytest v5.4.0 (released on March 12th 2020) #187

Closed

Natim mentioned this pull request Mar 27, 2020

Get rid of pytest-sugar mozilla-services/kinto-amo#148

Merged

This comment has been minimized.

Sign in to view

webknjaz added a commit to cherrypy/cheroot that referenced this pull request Mar 28, 2020

Temporary limit pytest<5.4

acdd752

Refs: * Teemu/pytest-sugar#188 * pytest-dev/pytest#6931

jaraco pushed a commit to cherrypy/cheroot that referenced this pull request Apr 10, 2020

Temporary limit pytest<5.4

7b4078e

Refs: * Teemu/pytest-sugar#188 * pytest-dev/pytest#6931

iwootten mentioned this pull request Apr 11, 2020

Update python version to 3.8 ONSdigital/eq-questionnaire-runner#94

Merged

webknjaz added a commit to cherrypy/cherrypy that referenced this pull request Apr 17, 2020

Temporary limit pytest<5.4

126eda5

Refs: * Teemu/pytest-sugar#188 * pytest-dev/pytest#6931

Teemu merged commit 5a3f0cc into Teemu:master Apr 26, 2020

webknjaz added a commit to cherrypy/cheroot that referenced this pull request Jul 13, 2020

Bump pytest-sugar to v0.9.3

6c74b27

Ref: Teemu/pytest-sugar#188 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to pytest 5.4.0 API #188

Update to pytest 5.4.0 API #188

GuillaumeFavelier commented Mar 13, 2020

GuillaumeFavelier commented Mar 13, 2020 •

edited

GuillaumeFavelier commented Mar 13, 2020

blueyed commented Mar 13, 2020

codecov-io commented Mar 13, 2020 •

edited

GuillaumeFavelier commented Mar 13, 2020

GuillaumeFavelier commented Mar 13, 2020

GuillaumeFavelier commented Mar 13, 2020

SVilgelm commented Mar 15, 2020

breneser commented Mar 26, 2020

blueyed commented Mar 26, 2020 •

edited

This comment has been minimized.

This comment has been minimized.

truthdoug commented Mar 27, 2020

Teemu commented Apr 26, 2020

Teemu commented Apr 26, 2020

Update to pytest 5.4.0 API #188

Update to pytest 5.4.0 API #188

Conversation

GuillaumeFavelier commented Mar 13, 2020

GuillaumeFavelier commented Mar 13, 2020 • edited

GuillaumeFavelier commented Mar 13, 2020

blueyed commented Mar 13, 2020

codecov-io commented Mar 13, 2020 • edited

Codecov Report

GuillaumeFavelier commented Mar 13, 2020

GuillaumeFavelier commented Mar 13, 2020

GuillaumeFavelier commented Mar 13, 2020

SVilgelm commented Mar 15, 2020

breneser commented Mar 26, 2020

blueyed commented Mar 26, 2020 • edited

This comment has been minimized.

This comment has been minimized.

truthdoug commented Mar 27, 2020

Teemu commented Apr 26, 2020

Teemu commented Apr 26, 2020

GuillaumeFavelier commented Mar 13, 2020 •

edited

codecov-io commented Mar 13, 2020 •

edited

blueyed commented Mar 26, 2020 •

edited