Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version to 3.8 #94

Merged
merged 12 commits into from May 12, 2020
Merged

Update python version to 3.8 #94

merged 12 commits into from May 12, 2020

Conversation

iwootten
Copy link
Contributor

@iwootten iwootten commented Apr 11, 2020

What is the context of this PR?

Updates runner to python 3.8, as per all validator and schema repos.

Our main blocker to doing this was that gevent did not have support for python 3.8 and took a large amount of time to install. Version 1.5 of gevent was recently released, providing this support.

Additionally, this PR:

  • removes the pinned version of grpcio, which was set when we were exploring different approaches to including new relic within runner. There has since been multiple releases of it.
  • pins the version of pylint, due to errors incorrectly raised on dynamic wtform classes

How to review

Check the tests pass. Check if the gevent installation takes abnormal length of time to install.

@iwootten iwootten marked this pull request as ready for review April 17, 2020 13:17
@pricem14pc pricem14pc self-requested a review May 1, 2020 10:36
Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully run unit tests, functional tests and docker build
gevent installation successful with no abnormal observations
Successfully deployed to Kubernetes with Helm and tested in GCP
Currently documenting successful performance tests

@iwootten
Copy link
Contributor Author

iwootten commented May 5, 2020

I think it worth bumping the versions in this given the PR is now almost a month old. As I mentioned gevent has had two releases in the interim.

@pricem14pc pricem14pc added the dont merge Don't merge this PR label May 6, 2020
@pricem14pc
Copy link
Contributor

Added a don't merge until the performance investigation documentation has been completed and reviewed.

@iwootten iwootten removed the dont merge Don't merge this PR label May 12, 2020
@iwootten iwootten merged commit d8a28bf into master May 12, 2020
@iwootten iwootten deleted the update-to-python-38 branch May 12, 2020 16:08
@pricem14pc pricem14pc added this to the v3.42.0 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants