-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python version to 3.8 #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully run unit tests, functional tests and docker build
gevent installation successful with no abnormal observations
Successfully deployed to Kubernetes with Helm and tested in GCP
Currently documenting successful performance tests
I think it worth bumping the versions in this given the PR is now almost a month old. As I mentioned gevent has had two releases in the interim. |
Added a don't merge until the performance investigation documentation has been completed and reviewed. |
What is the context of this PR?
Updates runner to python 3.8, as per all validator and schema repos.
Our main blocker to doing this was that gevent did not have support for python 3.8 and took a large amount of time to install. Version 1.5 of gevent was recently released, providing this support.
Additionally, this PR:
How to review
Check the tests pass. Check if the gevent installation takes abnormal length of time to install.