Student Profile: add a 'Upload/Edit Photo' tooltip

[delevko]

This tooltip will show size and formats of a photo. It would be easier for a student to look for available photos to submit.

There is a similar tooltip (shown in the screenshot below), but it also can be changed. For example, the new tooltip will look like this 'Upload a profile picture. Max size: 5MB .png .jpg'.

[delevko]

If this issue looks legit, I will work on it

[damithc]

If this issue looks legit, I will work on it

Go ahead @labirinto

[delevko]

@damithc
While running ./gradlew lint I get the following exception:
"Could not determine the dependencies of task ':compileTestJava'.

Could not create service of type AnnotationProcessorDetector using JavaGradleScopeServices.createAnnotationProcessorDetector()."

Can you please help me, what could it be?

[sukanta-27]

@labirinto
Did you go through the setting-up document while setting up the project?

[delevko]

@sukanta-27 yes. I did it again, now 'npm install' command gives the following output:
"
npm WARN ajv-keywords@3.1.0 requires a peer of ajv@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.1.3 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
"

[sukanta-27]

@wkurniawan07 @damithc @whipermr5

Guess there is a regression in the npm itself.
For reference :

• Hoisting dependencies with peerDependencies can lead to unmet peer dependencies npm/npm#19877
• UNMET PEER DEPENDENCY npm/npm#15708
• Pin: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1", causing a conf… eslint/eslint#10022

[sukanta-27]

@labirinto
What is your output for npm -v and node -v?

[delevko]

@sukanta-27 npm -v: 5.6.0
node -v: v8.9.4

[sukanta-27]

@labirinto Yup. There is a regression in npm itself.
Did you run npm install before or are you just running it after I pointed you to the setting up document?

Add: If you have completed all the other steps in the setting up document, can you then try running ./gradlew lint again? This is a warning sign, and not a error. It should not cause any serious issue.

[delevko]

@sukanta-27 . I did, and then it worked. I've just fixed this npm problem with this command:
"npm install --save-dev eslint eslint-config-airbnb eslint-plugin-jsx-a11y eslint-plugin-import eslint-plugin-react"
Then "./gradlew createConfigs"

But "./gradlew appengineStart" still gives the following output:
"
Could not determine the dependencies of task ':compileJava'.

Could not create service of type AnnotationProcessorDetector using JavaGradleScopeServices.createAnnotationProcessorDetector().
"

[sukanta-27]

@labirinto Can create an issue with Help template, so that these we can have some more information? Also provide the stackTrace?

[luanphamng]

Hello, I followed the Contributor Orientation Guide step by step. But in phase B, I can not make it has fewer than 5 failing test cases. The failing test cases is 6.
The message from IntelliJ is:

Test ignored.

Test ignored.

Test ignored.

Test ignored.

Mar 08, 2018 9:35:23 AM > com.google.appengine.api.datastore.dev.LocalDatastoreServicecleanupActiveServices
INFO: scheduler shutting down.

Any help ?

[tshradheya]

Not a problem, 5 is just a tentative number.

Try re-running only those 6 test cases and see if few of them pass.
Did you try running gradlew ciTests ? It reruns the failed tests up to 4 times and after that, all tests should pass

[gthd]

I would like to work on this issue.

[sukanta-27]

@gthd there is already an open PR for this issue, you can find another d.FirstTimers issue to work on.

[gthd]

ok sorry I didn't notice.

[jimmy51997]

@sukanta-27 ....I have finished working on this issue, I have run all the tests and they ran successfully.....the next step is to try pushing the changes to the master branch, right?

[sukanta-27]

@jimmy51997 Yes. 👍

[jimmy51997]

when i try to push the changes to the main repo...it says "unable to access 'https://github.com/TEAMMATES/teammates.git/': The requested URL returned error: 403".

Do i need to issue a pull request first??

@sukanta-27

[crphang]

@jimmy51997 you can take a look at our process guide https://github.com/TEAMMATES/teammates/blob/master/docs/process.md

[jimmy51997]

yes @crphang , that is what I am following now....it says to push changes to remote in point 4 of step 3. That's what I am trying to do.

[crphang]

@jimmy51997 It seems like you're not pushing to your fork.

[jimmy51997]

I should have my own version of project on my git-hub account....and I should be pushing there?? Is that what you mean?? @crphang