Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student Profile: add a 'Upload/Edit Photo' tooltip #8589 #8820

Closed

Conversation

jimmy51997
Copy link

Fixes #8589

Outline of Solution

The issue was solved by updating the Const.java file in the path "E:\Git Projects\teammates\src\main\java\teammates\common\util". In the file the value of the constant STUDENT_PROFILE_PICTURE in line 415 was changed to the required string showing the required specs of the image.

@jimmy51997
Copy link
Author

jimmy51997 commented May 13, 2018

Why did the Travis CI build failed @sukanta-27 @damithc @crphang ??

@bqnguyen94 bqnguyen94 changed the title Upload/Edit Photo' tooltip #8589 Student Profile: add a 'Upload/Edit Photo' tooltip #8589 May 16, 2018
@bqnguyen94
Copy link
Contributor

@jimmy51997 You can take a look at the Travis log and see what went wrong, which in this case is a UI test. I suggest you follow our dev guide for the testing process. For this issue this guide will be handy as well.

Also, please strictly follow our PR naming convention as detailed here. I have fixed it for you this time.

@jimmy51997
Copy link
Author

@bqnguyen94 where is the travis log?? I have followed the guides carefully already....what do i do to fix this failing CI test??

@bqnguyen94
Copy link
Contributor

You can click on Details below to see the Travis log.

@jimmy51997
Copy link
Author

@bqnguyen94 I saw the failed tests...those are the files i didn't modify a bit....now do i need to manually fix every tests??

@tanhengyeow
Copy link
Member

@jimmy51997 As mentioned by @bqnguyen94, please follow the resources that are linked to have a better idea on how to fix the issue you are currently facing.

To provide you with a little assistance, since you are making a UI change, HTML pages that are produced with your updated code would not match with the previous HTML pages used for testing, thus the errors shown in the Travis error log.

To save the trouble of manually updating every HTML pages affected by your UI change, GodMode is an efficient way provided to help you. I'll leave setting up GodMode and how to run it for you to figure out as they are all in the resources linked in #8820 (comment).

@tshradheya
Copy link
Member

Closing PR due to lack of activity. Feel free to reopen when you wish to resume work @jimmy51997

@tshradheya tshradheya closed this Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Student Profile: add a 'Upload/Edit Photo' tooltip
4 participants