-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Student: feedback submission: distribution points question: explain if equal points are not allowed #8817
Comments
@damithc ..... I would like to work on this issue.... anywhere I can get help from? |
@jimmy51997 As you are a first time contributor, I would advise you to start by taking one of our |
@sukanta-27 Every first timer issue seems already to be taken up....what should i do?? Say if i necessarily want to work on this issue, How to start? |
@jimmy51997 Figuring out what to do is a part of the task. I hope your work environment is set and you have run the app in dev server. If you haven't, do that first. |
@sukanta-27 I have set up the environment.........Thanks for the input. |
Also, #8589 doesn't seem to have an open PR, if you want you can take it. |
@sukanta-27 ....Are u sure it doesn't have an open PR?? If not how to know if it has an open PR or not? one more thing...does this project have a chat channel? |
@jimmy51997. Yes, no open PR is opened for it. You can look at the issue to see if a referenced PR is created to address it. A PR that fixes the issue should have '#issue_id' in the PR title and description. |
@crphang thanks...I think i got it now. |
@jimmy51997 For TEAMMATES, the issue tracker acts as a chat channel. If you have any problem or want to reach out to other developers (Like a help request, feature request etc), then you can open an issue for it. Do remember to follow the appropriate issue template while creating an issue. |
I would like to work on this issue |
@damithc Sir, is this what you had in mind ? I made use of the |
hmm... this is a neat way to get the job done but I'm a bit reluctant to piggy-back of visibility information for two reasons:
From a UIX point of view, it feels like the new instruction belongs together with the existing instruction shown in blue in your screenshot. |
@damithc I have changed it. I agree the visibility is poor. I was trying to make minimal changes to code to accomplish this. My bad. I have clubbed the instruction with the status display. The initial view is shown below: On halfway allocation of points, I display an error if any two allocations are same. In the end, if all points have been distributed, the error is still shown until all points are different. |
@mg14777 Just a thought, maybe |
@sukanta-27 Thanks for your suggestion. The reason why I put Error was to differentiate it from the first statement "All points distributed" since the second one is specifically an error not a generic statement. But maybe that's just me 😅 I can change that sure. |
@mg14777 Looks like we have two independent conditions but treat both of them as one. e.g., Even when all points are distributed, Good point @sukanta-27 but I guess no harm using the word |
@damithc The way it currently works is that the font color of both statements is dependent on whether there is an error or not. Once the user fixes the error |
Let's give it a try |
@damithc I have separated the conditions now. Error statements are displayed separately whenever needed. If all points have been distributed but some are same we display a green and red flag separately If some points are left to be distributed it is simply stated in blue If there is an overallocation two separate error statements are displayed for clarity |
Nice work!
|
@damithc Does this look intuitive |
Looks better. The current color choice is a bit fuzzy (e.g., total<400 is shown in blue). Shall we do the following?
In addition, and based on the actual points, we can also show these: |
I agree with most of them. Another thing to clarify, should I replace In the last statement, what should happen if there are multiple sets of repetitions ? For example, if 2 users have been allocated 22 and other 2 have been allocated 23. Should we display all such repetitions. Not sure if this is applicable here, but from a scalability perspective that might lead to a lot of repetitions to display? |
Yes, that's a good idea.
We can try that. Use the standard bootstrap glyphicons we use in other places.
Perhaps we limit to first duplication of points we detected? We can phrase it like this |
@damithc I have made the following changes Instructions are listed in blue and other notifications/messages follow Since currently the functionality is implemented commonly for both Distribute points among recipients and options type of questions, I have added this feature for Also I was wondering if I can create a PR and commit some of this now. |
Looks good. Yes, can start a PR to seek prelim comments about the implementation approach. |
…xplain if equal points are not allowed (#8836) * Distribute points questions enhancements * change html template id to match jquery selector name * instructions replaced + labels realigned * uneven distribution flag fix and among options enhancements * remove markup from tag files * update message logic for backward compatibility * improve styling code and function names * fix form submission error * update HTML files using God Mode * add browser tests and fix minor bugs * Update html files for remaining browser tests: God Mode * Update html files for FeedbackRubricQuestionUiTest.java * Update html pages for InstructorFeedbackEditPageUiTest.java * remove unused imports * fix indentation and instructions when recipient is hidden * add more browser tests * fix style errors * update html files for InstructorEditStudentFeedbackPageUiTest and FeedbackRankQuestionUiTest * add comments to explain logic * fix contrib padding and remove unnecessary comments * update HTML files * refresh repeated points buffer * improve comment and fix more info indent * update html files * fix indentation and typos
…estion: explain if equal points are not allowed (TEAMMATES#8836) * Distribute points questions enhancements * change html template id to match jquery selector name * instructions replaced + labels realigned * uneven distribution flag fix and among options enhancements * remove markup from tag files * update message logic for backward compatibility * improve styling code and function names * fix form submission error * update HTML files using God Mode * add browser tests and fix minor bugs * Update html files for remaining browser tests: God Mode * Update html files for FeedbackRubricQuestionUiTest.java * Update html pages for InstructorFeedbackEditPageUiTest.java * remove unused imports * fix indentation and instructions when recipient is hidden * add more browser tests * fix style errors * update html files for InstructorEditStudentFeedbackPageUiTest and FeedbackRankQuestionUiTest * add comments to explain logic * fix contrib padding and remove unnecessary comments * update HTML files * refresh repeated points buffer * improve comment and fix more info indent * update html files * fix indentation and typos
v6.5.1
Scenario:
A session has a 'distribute points' question. It requires all points to be different
Current: When a respondent is submitting responses, the submission is rejected if the student gives equal points to all recipients, which is the correct behavior. However, the question description doesn't mention that points need to be different. The restriction is revealed only when the student tries to submit.
Suggested: When the question is presented to the respondent, also explain that equal points are not acceptable. That way, the respondent doesn't have to discover the restriction by trial-and-error.
The text was updated successfully, but these errors were encountered: