fix: Use a null prototype object for this.files #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport Stuk#766 to v2.6.1
CleberL
approved these changes
Jul 29, 2022
Stuk
added a commit
that referenced
this pull request
Aug 2, 2022
|
Thanks for the wait. I've just published this as v2.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #766 to v2.6.1
Background for the change.
I'm maintainer of the https://github.com/optilude/xlsx-template and this library still use v2.6 because I do not see path how I can make update to latest JSZip without breaking existing library users. JSZip uses async everywhere and it's hard to provide path without breaking changes.
So if possible, I would like you to accept this change and release v2.6.2 version.