Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing "archiver" dependency to reduce install size #416

Closed
RandomByte opened this issue Jul 12, 2018 · 2 comments
Closed

Consider replacing "archiver" dependency to reduce install size #416

RandomByte opened this issue Jul 12, 2018 · 2 comments
Labels
dependencies Automated dependency update enhancement New feature or request module/ui5-builder Related to the UI5 Builder module
Projects
UI5 Tooling - Tasks

Comments

@RandomByte
Copy link
Member

https://github.com/archiverjs/node-archiver

❯ cd <empty directory>
❯ npm i archiver
❯ du -sh ./node_modules/
6.9M	./node_modules/

Related issues: archiverjs/node-archiver#197 and archiverjs/node-archiver#329

Possible alternatives (to be checked)

https://github.com/Stuk/jszip

❯ cd <empty directory>
❯ npm i jszip
❯ du -sh ./node_modules/
8.7M	./node_modules/

Related issue: Stuk/jszip#532

To be checked whether it matches our use-case.

https://github.com/cthackers/adm-zip

❯ cd <empty directory>
❯ npm i adm-zip
❯ du -sh ./node_modules/
168K	./node_modules/

To be checked whether it matches our use-case.
@RandomByte RandomByte changed the title Consider replacing archiver dependency Consider replacing "archiver" dependency to reduce install size Jul 12, 2018
@ctalkington
Copy link

just a note that archiver is going to be releasing some changes within the next month that reduce some of that lodash bloat which should help here.

@RandomByte
Copy link
Member Author

The archiver release 3.0.0 dropped the lodash dependency.

However, its dependency async in version 2.x still depends on lodash. async will drop lodash with the not yet released 3.0.0: caolan/async#1566

archiver will need to update its async dependency to ^3.0.0 after it has been released to actually stop lodash from being installed when installing archiver.

matz3 referenced this issue in SAP/ui5-builder Jan 3, 2019
@matz3
[INTERNAL] manifestBundler: Use "yazl" instead of "archiver" for zip
925abf0 
Archiver is a quite heavy dependency (see #63) and can be replaced with
"yazl".
Tests have also been adopted from adm-zip to extract-zip (which uses
"yauzl" under the hood).

Fixes: #63
matz3 referenced this issue in SAP/ui5-builder Jan 3, 2019
@matz3
[INTERNAL] manifestBundler: Use "yazl" instead of "archiver" for zip
b760a43 
Archiver is a quite heavy dependency (see #63) and can be replaced with
"yazl".
Tests have also been adopted from adm-zip to extract-zip (which uses
"yauzl" under the hood).

Fixes: #63
@RandomByte RandomByte transferred this issue from SAP/ui5-builder Nov 20, 2020
@RandomByte RandomByte added dependencies Automated dependency update enhancement New feature or request module/ui5-builder Related to the UI5 Builder module labels Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Automated dependency update enhancement New feature or request module/ui5-builder Related to the UI5 Builder module
Projects
UI5 Tooling - Tasks
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctalkington @RandomByte