Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential improvement, drop classNames dependency #135

Merged
merged 1 commit into from Nov 29, 2022
Merged

Potential improvement, drop classNames dependency #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 20 additions & 17 deletions src/index.tsx
View file
Open in desktop
@@ -1,5 +1,4 @@
import React, { CSSProperties, useEffect, useRef, useState } from 'react';
import classNames from 'classnames';

// ------------------ Types

Expand Down Expand Up @@ -68,12 +67,14 @@ function getStaticStateClasses(
animationStateClasses: AnimationStateClasses,
height: Height
) {
return classNames({
[animationStateClasses.static]: true,
[animationStateClasses.staticHeightZero]: height === 0,
[animationStateClasses.staticHeightSpecific]: height > 0,
[animationStateClasses.staticHeightAuto]: height === 'auto',
});
return [
animationStateClasses.static,
height === 0 && animationStateClasses.staticHeightZero,
height > 0 && animationStateClasses.staticHeightSpecific,
height === 'auto' && animationStateClasses.staticHeightAuto,
]
.filter((v) => v)
.join(' ');
}

// ------------------ Component
Expand Down Expand Up @@ -208,16 +209,18 @@ const AnimateHeight: React.FC<AnimateHeightProps> = ({
}

// Animation classes
const newAnimationStateClassNames = classNames({
[stateClasses.current.animating]: true,
[stateClasses.current.animatingUp]:
prevHeight.current === 'auto' || height < prevHeight.current,
[stateClasses.current.animatingDown]:
height === 'auto' || height > prevHeight.current,
[stateClasses.current.animatingToHeightZero]: timeoutHeight === 0,
[stateClasses.current.animatingToHeightAuto]: timeoutHeight === 'auto',
[stateClasses.current.animatingToHeightSpecific]: timeoutHeight > 0,
});
const newAnimationStateClassNames = [
stateClasses.current.animating,
(prevHeight.current === 'auto' || height < prevHeight.current) &&
stateClasses.current.animatingUp,
(height === 'auto' || height > prevHeight.current) &&
stateClasses.current.animatingDown,
timeoutHeight === 0 && stateClasses.current.animatingToHeightZero,
timeoutHeight === 'auto' && stateClasses.current.animatingToHeightAuto,
timeoutHeight > 0 && stateClasses.current.animatingToHeightSpecific,
]
.filter((v) => v)
.join(' ');

// Animation classes to be put after animation is complete
const timeoutAnimationStateClasses = getStaticStateClasses(
Expand Down