Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential improvement, drop classNames dependency #135

Merged
merged 1 commit into from Nov 29, 2022
Merged

Potential improvement, drop classNames dependency #135

merged 1 commit into from Nov 29, 2022

Commits on Nov 25, 2022

  1. Potential improvement, drop classNames dependency 

    Hi I think there's a potential here to drop the classNames dependency. 

Here I've replaced it with:
- add classes to an array (some will be false if conditions aren't met)
- filter for truthy values
- join array elements with a space

I 100% don't mind if you don't merge. I have done this work anyway for my own project.

Cheers, Davey
    @EarthlingDavey
    EarthlingDavey committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    f0423ca View commit details
    Browse the repository at this point in the history