Potential improvement, drop classNames dependency #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi I think there's a potential here to drop the classNames dependency. Here I've replaced it with: - add classes to an array (some will be false if conditions aren't met) - filter for truthy values - join array elements with a space I 100% don't mind if you don't merge. I have done this work anyway for my own project. Cheers, Davey
|
Hi @EarthlingDavey, Cheers! |
|
Awesome, and thanks for the project BTW. I just dropped it into my app and it works 100% - will reccomend :) |
|
Thanks again, released in 3.1.0 🎉 |
|
No problem bud 🎉✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I think there's a potential here to drop the classNames dependency.
Here I've replaced it with:
I 100% don't mind if you don't merge. I have done this work anyway for my own project.
Cheers, Davey