Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO JIRA]: Updating propTypes package and fixing incorrect proptypes #2261

Merged
merged 4 commits into from Sep 10, 2021
Merged

[NO JIRA]: Updating propTypes package and fixing incorrect proptypes #2261

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0c4a11
[NO JIRA]: Updating propTypes package and fixing incorrect proptypes
olliecurtis Sep 8, 2021
e9f7b69
Update UNRELEASED.md
olliecurtis Sep 8, 2021
aa24cc7
Addressing feedback comments
olliecurtis Sep 9, 2021
06b40d7
Correcting propType docs for infinte scroll
olliecurtis Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .spelling
View file
Open in desktop
Expand Up @@ -230,6 +230,7 @@ Animated.Image
arrayOf
bool
displayName
elementType
FlatList
func
instanceOf
Expand Down
9 changes: 9 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
@@ -0,0 +1,9 @@
**Fixed:**
- Updated `prop-types` to version `15.7.2`

- bpk-component-barchart:
- bpk-component-calendar:
- bpk-component-datepicker:
- bpk-component-infinite-scroll:
- bpk-theming:
- Corrected component props to allow `elementType` for the correct props when components are being used.
olliecurtis marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion packages/bpk-animate-height/package.json
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
},
"gitHead": "5c156b97cb0ba5e75851d3c763334578714c895e",
"dependencies": {
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-accordion/package.json
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
"bpk-component-text": "^4.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-autosuggest/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-input": "^6.0.19",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2",
"prop-types": "^15.7.2",
"react-autosuggest": "^9.4.3"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-badge/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-banner-alert/package.json
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@
"bpk-component-icon": "^9.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2",
"prop-types": "^15.7.2",
"react-transition-group": "^2.5.3"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-barchart/README.md
View file
Open in desktop
Expand Up @@ -64,7 +64,7 @@ export default () => (
| [onBarFocus](#onbarfocus) | func | false | null |
| [getBarLabel](#getbarlabel) | func | false | See prop details |
| [getBarSelection](#getbarselection) | func | false | See prop details |
| BarComponent | func | false | BpkBarchartBar |
| BarComponent | elementType | false | BpkBarchartBar |
| disableDataTable | bool | false | false |

### Theme Props
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-barchart/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"d3-path": "^2.0.0",
"d3-scale": "^3.3.0",
"lodash.debounce": "^4.0.8",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-barchart/src/BpkBarchart.js
View file
Open in desktop
Expand Up @@ -329,7 +329,7 @@ BpkBarchart.propTypes = {
onBarFocus: PropTypes.func,
getBarLabel: PropTypes.func,
getBarSelection: PropTypes.func,
BarComponent: PropTypes.func,
BarComponent: PropTypes.elementType,
disableDataTable: PropTypes.bool,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-barchart/src/BpkBarchartBars.js
View file
Open in desktop
Expand Up @@ -143,7 +143,7 @@ BpkBarchartBars.propTypes = {
right: PropTypes.number,
}).isRequired,
getBarLabel: PropTypes.func.isRequired,
BarComponent: PropTypes.func.isRequired,
BarComponent: PropTypes.elementType.isRequired,

getBarSelection: PropTypes.func,
outerPadding: PropTypes.number,
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-blockquote/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-breadcrumb/package.json
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
"bpk-component-text": "^4.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-breakpoint/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2",
"prop-types": "^15.7.2",
"react-responsive": "^6.1.2"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-button/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"gitHead": "5c156b97cb0ba5e75851d3c763334578714c895e",
"dependencies": {
"bpk-mixins": "^23.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"devDependencies": {
"bpk-storybook-utils": "^1.0.10"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-calendar/README.md
View file
Open in desktop
Expand Up @@ -221,7 +221,7 @@ The BpkCalendarGrid component displays a month as a table.

| Property | PropType | Required | Default Value |
| --------------------- | -------------------- | -------- | ---------------- |
| DateComponent | func | true | - |
| DateComponent | elementType | true | - |
| daysOfWeek | array(object) | true | - |
| formatDateFull | func | true | - |
| formatMonth | func | true | - |
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-calendar/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"date-fns": "^2.21.1",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-calendar/src/BpkCalendarGrid.js
View file
Open in desktop
Expand Up @@ -165,7 +165,7 @@ class BpkCalendarGrid extends Component {

export const propTypes = {
// Required
DateComponent: PropTypes.func.isRequired,
DateComponent: PropTypes.elementType.isRequired,
daysOfWeek: CustomPropTypes.DaysOfWeek.isRequired,
formatDateFull: PropTypes.func.isRequired,
formatMonth: PropTypes.func.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-calendar/src/BpkCalendarGridTransition.js
View file
Open in desktop
Expand Up @@ -195,7 +195,7 @@ class BpkCalendarGridTransition extends Component {
}

BpkCalendarGridTransition.propTypes = {
TransitionComponent: PropTypes.func.isRequired,
TransitionComponent: PropTypes.elementType.isRequired,
className: PropTypes.string,
month: PropTypes.instanceOf(Date),
focusedDate: PropTypes.instanceOf(Date),
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-calendar/src/Week.js
View file
Open in desktop
Expand Up @@ -283,7 +283,7 @@ class Week extends Component {
}

Week.propTypes = {
DateComponent: PropTypes.func.isRequired,
DateComponent: PropTypes.elementType.isRequired,
dateModifiers: CustomPropTypes.DateModifiers.isRequired,
dates: PropTypes.arrayOf(Date).isRequired,
daysOfWeek: CustomPropTypes.DaysOfWeek.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-card/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"devDependencies": {
"bpk-component-link": "^3.0.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-checkbox/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-icon": "^9.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-chip/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-icon": "^9.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-close-button/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-icon": "^9.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"devDependencies": {
"bpk-storybook-utils": "^1.0.10"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-code/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-content-container/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-datatable/package.json
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"lodash": "^4.17.20",
"prop-types": "^15.6.2",
"prop-types": "^15.7.2",
"react-virtualized": "^9.22.3"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-datepicker/README.md
View file
Open in desktop
Expand Up @@ -134,7 +134,7 @@ For more information on some these props, check the BpkCalendar documentation.
| formatDate | func | true | - |
| formatDateFull | func | true | - |
| formatMonth | func | true | - |
| calendarComponent | oneOfType(func, node) | false | BpkCalendar |
| calendarComponent | elementType | false | BpkCalendar |
| date | Date | false | null |
| dateModifiers | object | false | {} (\*) |
| inputProps | object | false | {} |
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-datepicker/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"bpk-component-popover": "^4.0.17",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-datepicker/src/BpkDatepicker.js
View file
Open in desktop
Expand Up @@ -207,7 +207,7 @@ BpkDatepicker.propTypes = {
previousMonthLabel: PropTypes.string.isRequired,
weekStartsOn: PropTypes.number.isRequired,
// Optional
calendarComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]),
calendarComponent: PropTypes.elementType,
date: PropTypes.instanceOf(Date),
dateModifiers: CustomPropTypes.DateModifiers,
inputProps: PropTypes.object, // eslint-disable-line react/forbid-prop-types
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-description-list/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-dialog/package.json
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"bpk-scrim-utils": "^5.0.10",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-drawer/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"bpk-scrim-utils": "^5.0.10",
"prop-types": "^15.6.2",
"prop-types": "^15.7.2",
"react-transition-group": "^2.5.3"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-fieldset/package.json
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@
"bpk-component-label": "^5.0.10",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-flare/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"bpk-component-text": "^4.0.12",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-form-validation/examples.js
View file
Open in desktop
Expand Up @@ -95,7 +95,7 @@ class InputContainer extends Component {
}

InputContainer.propTypes = {
FormComponent: PropTypes.func.isRequired,
FormComponent: PropTypes.elementType.isRequired,
};

const DefaultExample = () => (
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-form-validation/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-animate-height": "^4.0.10",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-grid-toggle/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-link": "^3.0.10",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-grid/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-heading/package.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-horizontal-nav/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-mobile-scroll-container": "^3.0.11",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"peerDependencies": {
"react": "^16.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-icon/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"@skyscanner/bpk-svgs": "^14.0.4",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2"
"prop-types": "^15.7.2"
},
"devDependencies": {
"bpk-component-button": "^5.0.9",
Expand Down
2 changes: 1 addition & 1 deletion packages/bpk-component-image/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"bpk-component-spinner": "^5.0.4",
"bpk-mixins": "^23.0.0",
"bpk-react-utils": "^4.0.0",
"prop-types": "^15.6.2",
"prop-types": "^15.7.2",
"react-transition-group": "^2.5.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/bpk-component-infinite-scroll/README.md
View file
Open in desktop
Expand Up @@ -170,8 +170,8 @@ Updates the internal array and triggers all listeners.
| loaderMinDisplay | oneOf(['small', 'half', 'full']) | false | 'full' |
| onScroll | func | false | null |
| onScrollFinished | func | false | null |
| renderLoadingComponent | func | false | null |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed back to func too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Solved!

| renderSeeMoreComponent | func | false | null |
| renderLoadingComponent | elementType | false | null |
| renderSeeMoreComponent | elementType | false | null |
| seeMoreAfter | number | false | null |

## `elementsPerScroll`
Expand Down