[NO JIRA]: Updating propTypes package and fixing incorrect proptypes #2261
Conversation
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers, |
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2261 to see this build running in a browser. |
| @@ -75,8 +75,8 @@ const propTypes = { | |||
| loaderIntersectionTrigger: PropTypes.oneOf(['small', 'half', 'full']), | |||
| onScroll: PropTypes.func, | |||
| onScrollFinished: PropTypes.func, | |||
| renderLoadingComponent: PropTypes.func, | |||
There was a problem hiding this comment.
Both of these are actually treated as functions, not React components so this is not correct. That said I don't think there's a down side to start treating them as components
There was a problem hiding this comment.
Ah yes I see, maybe it does make sense to keep it as that given how its used in comparios to other things
Co-authored-by: Hugo Tunius <h@tunius.se>
| @@ -170,8 +170,8 @@ Updates the internal array and triggers all listeners. | |||
| | loaderMinDisplay | oneOf(['small', 'half', 'full']) | false | 'full' | | |||
| | onScroll | func | false | null | | |||
| | onScrollFinished | func | false | null | | |||
| | renderLoadingComponent | func | false | null | | |||
There was a problem hiding this comment.
This should be changed back to func too
This PR solves two things:
propTypesto latest version to allow use ofelementTypeprop (see more)funcbut in newer React versions its not strictly the caseRemember to include the following changes:
UNRELEASED.md(See How to write a good changelog entry)README.md