Check test RBI files for well-formedness #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't get proper exit codes if `--quiet` is supplied. Ref: sorbet/sorbet#4761
paracycle
force-pushed
the
uk-check-dsl-rbi-files-for-parse-errors
branch
from
ee1bfec
to
2775d2b
Compare
Morriar
reviewed
Oct 21, 2021
vinistock
reviewed
Oct 21, 2021
| cmd << "--quiet" if quiet | ||
| cmd |= args | ||
|
|
||
| File.write("foo.rb", cmd.to_s) |
There was a problem hiding this comment.
Why do we need to write this?
There was a problem hiding this comment.
Lol, we don't. It is a left-over from my troubleshooting. 🤦
KaanOzkan
reviewed
Oct 25, 2021
| ) | ||
|
|
||
| assert($?.success?, <<~MSG) # rubocop:disable Style/SpecialGlobalVars | ||
| Expected generated RBI file for `#{constant_name}` with no parsing errors. |
There was a problem hiding this comment.
Nitpick: Grammar is off with this sentence. Something like this is more clear:
Suggested change
| Expected generated RBI file for `#{constant_name}` with no parsing errors. | |
| Expected generated RBI file for `#{constant_name}` to not have any parsing errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@ryanwilsonperkin caught a problem with the RBI output in Active Record relations generator, which reminded me that we should be checking RBI files for well-formedness automatically in every test.
Implementation
After every RBI file is generated as a string, we pass it through Sorbet and just check the error-code. If there is an error, we show the Sorbet output which should help figure out the problem.
Tests
No automated test cases.