New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check RBI syntax in DslCompiler test helper #1870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of running type checking instead if it's not too slow to cover other potential issues.
I agree with @KaanOzkan, checking the generated files with Sorbet will provide more value. You can take a look at this old draft trying to do exactly that: #554. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment.
00ebfd9
to
15609d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
15609d7
to
bb4365c
Compare
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
bb4365c
to
8304179
Compare
Motivation
Prevent #1867 from happening again.
Closes #554 (supersedes it)
Implementation
Sorbet sigs are valid Ruby syntax, so the bad code that aforementioned PR fixes will fail:
Tests
Added tests.