Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep linting to code #632

Merged
merged 2 commits into from
Apr 30, 2024
Merged

keep linting to code #632

merged 2 commits into from
Apr 30, 2024

Conversation

tobi
Copy link
Member

@tobi tobi commented Apr 30, 2024

this is coming from a good place, but is not within the scope of what a linter should do

this is coming from a good place, but is not within the scope of what a linter should do
@tobi tobi requested a review from a team as a code owner April 30, 2024 13:47
@github-actions github-actions bot added the config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops label Apr 30, 2024
This automated commit dumps the contents of the full RuboCop config.
[dependabot skip]
@burke
Copy link
Member

burke commented Apr 30, 2024

It's kind of a shame in general that we can't operate more in a go fmt / rust fmt kind of mode here (rules so simple, obviously correct, and programmatically resolvable that it's typical and expected to autofix on file save), especially with ruby being as idiomatically expressive as it is. Even apart from this particularly opinionated rule, there's a whole suite of opinions in here that go well beyond what my personal preferences for a linter would point to.

Anyway, wider issue that that we're clearly not going to be able to resolve today.

@tobi tobi merged commit 8f4cf03 into main Apr 30, 2024
24 checks passed
@tobi tobi deleted the language branch April 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants