Skip to content

Commit

Permalink
Merge pull request #632 from Shopify/language
Browse files Browse the repository at this point in the history
keep linting to code
  • Loading branch information
tobi committed Apr 30, 2024
2 parents e9400e0 + 910e9ff commit 8f4cf03
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 27 deletions.
15 changes: 0 additions & 15 deletions rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -389,21 +389,6 @@ Naming/HeredocDelimiterCase:
Naming/HeredocDelimiterNaming:
Enabled: false

Naming/InclusiveLanguage:
Enabled: true
FlaggedTerms:
master:
Suggestions:
- main
- primary
- leader
AllowedRegex:
- !ruby/regexp '/master[_\s\.]key/' # Rails master key
- !ruby/regexp /\w*:\/\/\S+/ # URLs (e.g. https://github.com/org/repo/blob/master/README.md)
- !ruby/regexp '/(?:blob|tree)/master/' # e.g. github.com/org/repo/blob/master/README.md, without https://
- !ruby/regexp '/origin[ \/]master/' # Legacy default git branch name
- !ruby/regexp '/(?<=[a-z])master|master(?=[a-z])/' # "master" substring within a longer word

Naming/MemoizedInstanceVariableName:
Enabled: false

Expand Down
13 changes: 1 addition & 12 deletions test/fixtures/full_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2141,7 +2141,7 @@ Naming/HeredocDelimiterNaming:
- !ruby/regexp /(^|\s)(EO[A-Z]{1}|END)(\s|$)/i
Naming/InclusiveLanguage:
Description: Recommend the use of inclusive language instead of problematic terms.
Enabled: true
Enabled: false
VersionAdded: '1.18'
VersionChanged: '1.49'
CheckIdentifiers: true
Expand All @@ -2168,17 +2168,6 @@ Naming/InclusiveLanguage:
- replica
- secondary
- follower
master:
Suggestions:
- main
- primary
- leader
AllowedRegex:
- !ruby/regexp /master[_\s\.]key/
- !ruby/regexp /\w*:\/\/\S+/
- !ruby/regexp /(?:blob|tree)\/master/
- !ruby/regexp /origin[ \/]master/
- !ruby/regexp /(?<=[a-z])master|master(?=[a-z])/
Naming/MemoizedInstanceVariableName:
Description: Memoized method name should match memo instance variable name.
Enabled: false
Expand Down

0 comments on commit 8f4cf03

Please sign in to comment.