Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.28.2 to 1.29.0 #386

Merged
merged 2 commits into from May 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
Expand Up @@ -26,12 +26,12 @@ GEM
rake (13.0.6)
regexp_parser (2.3.1)
rexml (3.2.5)
rubocop (1.28.2)
rubocop (1.29.0)
parallel (~> 1.10)
parser (>= 3.1.0.0)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.17.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
Expand Down
18 changes: 18 additions & 0 deletions rubocop.yml
Expand Up @@ -190,6 +190,9 @@ Lint/RedundantWithIndex:
Lint/RedundantWithObject:
Enabled: false

Lint/RefinementImportMethods:
Enabled: false

Lint/RegexpAsCondition:
Enabled: false

Expand Down Expand Up @@ -343,6 +346,9 @@ Naming/RescuedExceptionsVariableName:
Naming/VariableNumber:
Enabled: false

Security/CompoundHash:
Enabled: false

Security/MarshalLoad:
Enabled: false

Expand Down Expand Up @@ -427,6 +433,9 @@ Style/Encoding:
Style/EndlessMethod:
Enabled: false

Style/EnvHome:
Enabled: false

Style/EvalWithLocation:
Enabled: false

Expand All @@ -436,6 +445,9 @@ Style/ExpandPathArguments:
Style/ExponentialNotation:
Enabled: false

Style/FetchEnvVar:
Enabled: false

Style/FileRead:
Enabled: false

Expand Down Expand Up @@ -571,6 +583,9 @@ Style/NumericLiterals:
Style/NumericPredicate:
Enabled: false

Style/ObjectThen:
Enabled: false

Style/OpenStructUse:
Enabled: true

Expand Down Expand Up @@ -607,6 +622,9 @@ Style/RedundantFetchBlock:
Style/RedundantFileExtensionInRequire:
Enabled: false

Style/RedundantInitialize:
Enabled: false

Style/RedundantRegexpCharacterClass:
Enabled: false

Expand Down
32 changes: 23 additions & 9 deletions test/fixtures/full_config.yml
Expand Up @@ -166,6 +166,17 @@ Gemspec/DateAssignment:
VersionAdded: '1.10'
Include:
- "**/*.gemspec"
Gemspec/DependencyVersion:
Description: Requires or forbids specifying gem dependency versions.
Enabled: false
VersionAdded: '1.29'
EnforcedStyle: required
SupportedStyles:
- required
- forbidden
Include:
- "**/*.gemspec"
AllowedGems: []
Gemspec/DuplicatedAssignment:
Description: An attribute assignment method calls should be listed only once in
a gemspec.
Expand Down Expand Up @@ -1484,7 +1495,7 @@ Lint/RedundantWithObject:
Lint/RefinementImportMethods:
Description: Use `Refinement#import_methods` when using `include` or `prepend` in
`refine` block.
Enabled: pending
Enabled: false
SafeAutoCorrect: false
VersionAdded: '1.27'
Lint/RegexpAsCondition:
Expand Down Expand Up @@ -1703,10 +1714,6 @@ Lint/UselessAssignment:
StyleGuide: "#underscore-unused-vars"
Enabled: true
VersionAdded: '0.11'
Lint/UselessElseWithoutRescue:
Description: Checks for useless `else` in `begin..end` without `rescue`.
Enabled: true
VersionAdded: '0.17'
Lint/UselessMethodDefinition:
Description: Checks for useless method definitions.
Enabled: false
Expand Down Expand Up @@ -2067,6 +2074,7 @@ Naming/VariableName:
- snake_case
- camelCase
AllowedIdentifiers: []
AllowedPatterns: []
Naming/VariableNumber:
Description: Use the configured style when numbering symbols, methods and variables.
StyleGuide: "#snake-case-symbols-methods-vars-with-numbers"
Expand All @@ -2087,10 +2095,11 @@ Naming/VariableNumber:
- rfc822
- rfc2822
- rfc3339
AllowedPatterns: []
Security/CompoundHash:
Description: When overwriting Object#hash to combine values, prefer delegating to
Array#hash over writing a custom implementation.
Enabled: pending
Enabled: false
VersionAdded: '1.28'
Security/Eval:
Description: The use of eval represents a serious security risk.
Expand Down Expand Up @@ -2566,6 +2575,11 @@ Style/EndlessMethod:
- allow_single_line
- allow_always
- disallow
Style/EnvHome:
Description: Checks for consistent usage of `ENV['HOME']`.
Enabled: false
Safe: false
VersionAdded: '1.29'
Style/EvalWithLocation:
Description: Pass `__FILE__` and `__LINE__` to `eval` method, as they are used by
backtraces.
Expand Down Expand Up @@ -2603,7 +2617,7 @@ Style/FetchEnvVar:
Description: This cop suggests `ENV.fetch` for the replacement of `ENV[]`.
Reference:
- https://rubystyle.guide/#hash-fetch-defaults
Enabled: pending
Enabled: false
VersionAdded: '1.28'
AllowedVars: []
Style/FileRead:
Expand Down Expand Up @@ -3218,7 +3232,7 @@ Style/ObjectThen:
Description: Enforces the use of consistent method names `Object#yield_self` or
`Object#then`.
StyleGuide: "#object-yield-self-vs-object-then"
Enabled: pending
Enabled: false
VersionAdded: '1.28'
EnforcedStyle: then
SupportedStyles:
Expand Down Expand Up @@ -3416,7 +3430,7 @@ Style/RedundantFreeze:
VersionChanged: '0.66'
Style/RedundantInitialize:
Description: Checks for redundant `initialize` methods.
Enabled: pending
Enabled: false
Safe: false
AllowComments: true
VersionAdded: '1.27'
Expand Down