Bump rubocop from 1.28.2 to 1.29.0 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.28.2 to 1.29.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.28.2...v1.29.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
volmer,
rafaelfranca and
a team
as code owners
dependabot
bot
added
dependencies
|
cc @Shopify/rails -- I'd like to bump Rubocop ahead of releasing a new version of the style guide (which I'd like to do so that these changes can be released). What's our policy on enabling new cops? I've enabled only the |
adrianna-chang-shopify
force-pushed
the
dependabot/bundler/rubocop-1.29.0
branch
from
d4554ca
to
e29fd89
Compare
adrianna-chang-shopify
approved these changes
May 12, 2022
nvasilevski
approved these changes
May 12, 2022
adrianna-chang-shopify
force-pushed
the
dependabot/bundler/rubocop-1.29.0
branch
from
e29fd89
to
67af467
Compare
|
After speaking with Rafael, the guideline is to disable all new cops when bumping Rubocop. New cops can be problematic if they don't have autocorrects. It's better to turn on new cops as we see fit, separate from bumping Rubocop. |
This was referenced May 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.28.2 to 1.29.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
2f2b2a7Cut 1.29e6a5a94Update Changelog1b6bda4Support the cases that there is a method call in each branch070ffea[Fix #10325] EnhanceStyle/RedundantConditionby considering the case that ...3439417Remove an old reference to version 1.05b7c91bTweak uniformity of expression was implemented914551a[Fix #10568] Add newStyle/EnvHomecop0d23a0aTweak highlight offense range forInternalAffairs/MethodNameEndWithcop73dfcf2Merge pull request #10600 from nobuyo/add-new-internal-affairs-method-name-en...6eadcd9Add newInternalAffairs/MethodNameEndWithcopDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)