Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop disabling Style/MutableConstant #349

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stop disabling Style/MutableConstant #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
493d24a
Stop disabling Style/MutableConstant
byroot Jan 13, 2022
57c2a73
Update the config and be explicit about the style
rafaelfranca Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rubocop.yml
View file
Open in desktop
Expand Up @@ -550,7 +550,7 @@ Style/MultipleComparison:
Enabled: false

Style/MutableConstant:
Enabled: false
EnforcedStyle: literals

Style/NegatedIfElseCondition:
Enabled: false
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/full_config.yml
View file
Open in desktop
Expand Up @@ -3014,7 +3014,7 @@ Style/MultipleComparison:
AllowMethodComparison: true
Style/MutableConstant:
Description: Do not assign mutable objects to constants.
Enabled: false
Enabled: true
VersionAdded: '0.34'
VersionChanged: '1.8'
SafeAutoCorrect: false
Expand Down