Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop disabling Style/MutableConstant #349

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Commits on Jan 13, 2022

  1. Stop disabling Style/MutableConstant

    I couldn't find any discussion about this cop, but I believe it's a positive one.
    
    First there's the correctness argument. If a constant is mutable is it really a constant?
    
    Then there's a performance argument. Hashes unless frozen are mutated uppon iteration
    (their internal `iter_level` attribute is incremented). This cause constant hashes that
    are in a clean CoW region to invalidate the entire 4kiB memory page.
    byroot committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    493d24a View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Configuration menu
    Copy the full SHA
    57c2a73 View commit details
    Browse the repository at this point in the history