Skip to content

Commit

Permalink
Enable Style/ExplicitBlockArgument cop
Browse files Browse the repository at this point in the history
The code is disabled by default because in some cases
it could change the block arity which might fail if the block is
actualy a lambda.

However I enabled it on Rails and shopify-core and it went just fine.

Since this cop is beneficial for production performance and
for triming CI backtraces a bit, I think we should enable it.
  • Loading branch information
byroot committed Sep 6, 2021
1 parent 3db8341 commit 61a6451
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ Style/ExpandPathArguments:
Enabled: false

Style/ExplicitBlockArgument:
Enabled: false
Enabled: true

Style/ExponentialNotation:
Enabled: false
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/full_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2502,7 +2502,7 @@ Style/ExplicitBlockArgument:
Description: Consider using explicit block argument to avoid writing block literal
that just passes its arguments to another block.
StyleGuide: "#block-argument"
Enabled: false
Enabled: true
VersionAdded: '0.89'
VersionChanged: '1.8'
Style/ExponentialNotation:
Expand Down

0 comments on commit 61a6451

Please sign in to comment.