Avoid rubocop errors by skipping the version of rubocop with a bug #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2021
Merged
Larochelle
approved these changes
Jun 14, 2021
Hectorhammett
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rubocop 1.16.1 was released a couple of days ago, which introduced errors in CI (e.g. failing build https://github.com/Shopify/identity_cache/runs/2796385731)
Solution
I tested on the previous release of rubocop (1.16.0) and it didn't have the problem. I also tested against rubocop master and it was fixed there (specifically by ttps://github.com/rubocop/rubocop/pull/9862). So we can just skip the rubocop version with the bug until the next release.