Fix mocha deprecation #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
changed the base branch from
master
to
skip-rubocop-version-with-bug
Hectorhammett
approved these changes
Jun 14, 2021
The warning from running the tests was ``` Mocha deprecation warning at test/test_helper.rb:4:in `require': Require 'mocha/test_unit', 'mocha/minitest' or 'mocha/api' instead of 'mocha/setup' ```
dylanahsmith
force-pushed
the
fix-mocha-deprecation
branch
from
96bc426
to
5f7adc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch is based on #496 to avoid CI failures
The warning from running the tests was
Mocha deprecation warning at test/test_helper.rb:4:in `require': Require 'mocha/test_unit', 'mocha/minitest' or 'mocha/api' instead of 'mocha/setup'So I chose to use 'mocha/minitest', the most appropriate of the suggested changes recommended in that error message